fs: cancel in-flight stat on abort - #63142
Open
mertcanaltin wants to merge 1 commit into
Open
Conversation
nodejs-github-bot
added
fs
mertcanaltin
force-pushed
the
mert/fs-stat-inflight-fix
branch
from
May 6, 2026 05:18
4425502 to
e4d317e
Compare
Contributor
|
Drive-by: this looks like it's still not actually canceling the underlying call, which would involve invoking |
mertcanaltin
force-pushed
the
mert/fs-stat-inflight-fix
branch
from
May 7, 2026 19:42
e4d317e to
8149c79
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63142 +/- ##
==========================================
- Coverage 90.21% 90.16% -0.05%
==========================================
Files 751 751
Lines 253550 253557 +7
Branches 47813 47772 -41
==========================================
- Hits 228733 228623 -110
- Misses 16076 16193 +117
Partials 8741 8741
🚀 New features to boost your workflow:
|
mertcanaltin
force-pushed
the
mert/fs-stat-inflight-fix
branch
2 times, most recently
from
May 8, 2026 20:30
fc73958 to
6d3d629
Compare
Member
Author
|
Thanks for review @bakkot I added a new binding function for cancel |
Member
|
cc @nodejs/fs |
Member
Author
|
@Renegade334, could you review this pr? |
jasnell
approved these changes
Aug 15, 2026
mertcanaltin
force-pushed
the
mert/fs-stat-inflight-fix
branch
from
August 20, 2026 10:26
6d3d629 to
4913c16
Compare
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Member
Author
|
I measuring uv_cancel. |
Member
|
@mertcanaltin Merge commits don't work with Node.js tooling. Can you please rebase? |
Signed-off-by: Mert Can Altin <mertgold60@gmail.com>
mertcanaltin
force-pushed
the
mert/fs-stat-inflight-fix
branch
from
August 24, 2026 14:25
4eb1ce8 to
2d21670
Compare
Member
Author
|
Thanks @trivikr, I've rebased now and measured. UV_THREADPOOL_SIZE=1, pool blocked by a pbkdf2 job, all 10,000 stadiums that were aborted while the pool was clogged are actually cancelled.
|
mertcanaltin
changed the title
Member
Author
|
Update: The AbortError behavior was landed in main with #63143, leaving only the uv_cancel call that actually dropped the request from the threadpool queue in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AbortError behavior was landed in main with #63143, leaving only the uv_cancel call that actually dropped the request from the threadpool queue in this PR.